Ofer Schreiber has posted comments on this change. Change subject: packaging: Moved configuring ovirt-engine to utils. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File packaging/fedora/setup/common_utils.py Line 936: if (os.path.exists(basedefs.EXEC_ENCRYPT_PASS)): Any reason for this check? we will get an exception either way Line 949: return "" why would you return an empty string? -- To view, visit http://gerrit.ovirt.org/6332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeec79b342ebdd1b4ffabee32fd878313d8df725 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
