Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: select first element on changing list ......................................................................
userportal,webadmin: select first element on changing list - When removing all elements except one, the code that tries to auto select kicked in and would select the first element of the old list giving an illusion of duplicates for a split second. This patch fixes this by not auto selecting the only element immediately, but deferring it until the operation has completed and the list has been updated. Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131881 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/32387/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java index e097afc..35e8e0b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java @@ -154,11 +154,17 @@ } @Override - public void setRowData(int start, List<? extends T> values) { + public void setRowData(int start, final List<? extends T> values) { super.setRowData(start, values); selectionModel.resolveChanges(); if (values.size() == 1 && selectionModel.getSelectedList().isEmpty() && doAutoSelect) { - selectionModel.setSelected(values.get(0), true); + Scheduler.get().scheduleDeferred(new ScheduledCommand() { + + @Override + public void execute() { + selectionModel.setSelected(values.get(0), true); + } + }); doAutoSelect = false; } updateTableControls(); -- To view, visit http://gerrit.ovirt.org/32387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib1ccea11f00bbf21e5fd63d4293075152d25cb1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
