Lior Vernia has uploaded a new change for review. Change subject: webadmin: Disable buttons on ghost entry ......................................................................
webadmin: Disable buttons on ghost entry A relatively recent refactoring/enhancement caused a small regression in several widgets, this is now fixed by calling superclass implementation of toggleGhost() (or not overriding it to do nothing). That patch wasn't pushed to ovirt-engine-3.5, so this is not an issue there. Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/32404/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java index 701e7d2..b4b9ba2 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.java @@ -44,11 +44,6 @@ } @Override - protected void toggleGhost(ListModel<String> value, NicLabelEditor widget, boolean becomingGhost) { - // do nothing, widgets look the same as ghost widgets (only one UI field) - } - - @Override public void edit(NicLabelModel model) { suggestions = model.getSuggestedLabels(); super.edit(model); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java index 17bf6d6..050355f 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/DnsServersWidget.java @@ -37,9 +37,4 @@ protected boolean isGhost(EntityModel<String> value) { return StringUtils.isEmpty(value.getEntity()); } - - @Override - protected void toggleGhost(EntityModel<String> value, DnsServerEditor widget, boolean becomingGhost) { - // do nothing, widgets look the same as ghost widgets (only one UI field) - } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java index 26e639f..e67f121 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java @@ -59,6 +59,7 @@ @Override protected void toggleGhost(VnicProfileModel value, VnicProfileWidget widget, boolean becomingGhost) { + super.toggleGhost(value, widget, becomingGhost); widget.publicUseEditor.setEnabled(!becomingGhost && value.getPublicUse().getIsChangable()); widget.networkQoSEditor.setEnabled(!becomingGhost && value.getNetworkQoS().getIsChangable()); } -- To view, visit http://gerrit.ovirt.org/32404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iafe35b1f4bdbee8068ea79629342518ca3405a62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
