Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix group searching in 389ds/RHDS ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32405/1//COMMIT_MSG Commit Message: Line 6: Line 7: aaa: Fix group searching in 389ds/RHDS Line 8: Line 9: The search now includes objectClass=posixGroup Line 10: Bug-Url: https://bugzilla.redhat.com/1133137 mistake? Line 11: Line 12: Topic: AAA Line 13: Change-Id: I8f030fbf8026d33953dc05081fd6f300fca7cdfe http://gerrit.ovirt.org/#/c/32405/1/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapQueryMetadataFactoryImpl.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapQueryMetadataFactoryImpl.java: Line 449: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$GIVENNAME, "givenname"); Line 450: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$USER_ACCOUNT_TYPE, "&(objectClass=person)"); Line 451: // We put here a duplicate. Need to solve it in another way. Line 452: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$PRINCIPAL_NAME, "uid"); Line 453: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$LDAP_GROUP_CATEGORY, "(|(objectClass=groupOfUniqueNames)(objectClass=posixGroup))"); please notice that you will get user id!!! not DN from this attribute Line 454: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$CN, "cn"); Line 455: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$USER_ACCOUNT_NAME, "uid"); Line 456: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$SN, "SN"); Line 457: dsSearchSyntaxMap.put(SearchLangageLDAPTokens.$SAMACCOUNTNAME, "uid"); -- To view, visit http://gerrit.ovirt.org/32405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f030fbf8026d33953dc05081fd6f300fca7cdfe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
