Sahina Bose has posted comments on this change. Change subject: engine: Change to geo-replication entities ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31795/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java: Line 113: Line 114: @Override Line 115: public int hashCode() { Line 116: final int prime = 31; Line 117: int result = 1; > sessionDetails should not be a part of hashCode and equals calculation? No, not required. Geo rep Session object's equality is determined by the fields used here. Line 118: result = prime * result + ((masterVolumeId == null) ? 0 : masterVolumeId.hashCode()); Line 119: result = prime * result + ((sessionId == null) ? 0 : sessionId.hashCode()); Line 120: result = prime * result + ((sessionKey == null) ? 0 : sessionKey.hashCode()); Line 121: result = prime * result + ((slaveHostName == null) ? 0 : slaveHostName.hashCode()); -- To view, visit http://gerrit.ovirt.org/31795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5367f24dd677b8628d90459b4ba8115c665bfde7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
