Lior Vernia has posted comments on this change. Change subject: webadmin: SetupNetwork- long network names shouldn't break the layout ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/32542/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml: Line 241: padding-top: 6px; Line 242: } Line 243: Line 244: .vlanLabel{ Line 245: padding-left: 3px; Please add margin/padding to the right as well, so the VLAN isn't pushed against the icons. Line 246: white-space: nowrap; Line 247: } Line 248: Line 249: .titleLabel{ http://gerrit.ovirt.org/#/c/32542/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java: Line 21: Label titleLabel; Line 22: Line 23: public NetworkPanel(LogicalNetworkModel item, NetworkPanelsStyle style, boolean draggable) { Line 24: super(item, style, draggable); Line 25: getElement().addClassName(item.getAttachedToNic() != null ? style.networkPanelAttached() Why is this needed? If you set the width for the other fields sub-elements in the panel (e.g. icons, VLAN), won't this work with the title label simply taking up the leftovers automatically? Line 26: : style.networkPanelNotAttached()); Line 27: if (item.isManagement()) { Line 28: getElement().addClassName(style.mgmtNetwork()); Line 29: } Line 154: @Override Line 155: protected void onLoad() { Line 156: super.onLoad(); Line 157: Line 158: while (ElementUtils.detectOverflowUsingScrollWidth(getElement())) { And if the width is set automatically according to the leftovers, this won't be needed either. Line 159: titleLabel.getElement().getStyle().setWidth(titleLabel.getElement().getClientWidth() - 1, Unit.PX); Line 160: } Line 161: } Line 162: -- To view, visit http://gerrit.ovirt.org/32542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife6ef384a5eac71398b397d8475ec312ed97eeb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
