Alon Bar-Lev has posted comments on this change. Change subject: core: Alert if priorities were overridden ......................................................................
Patch Set 2: (4 comments) minor formatting issues http://gerrit.ovirt.org/#/c/29180/2/src/otopi/context.py File src/otopi/context.py: Line 379: sequence.setdefault(m['stage'], []).append(m) Line 380: Line 381: prio_dep_reverses = [] Line 382: for stage, methods in sequence.items(): Line 383: for i,m in enumerate(methods[:-1]): space before m? Line 384: if m['priority'] > methods[i+1]['priority']: Line 385: prio_dep_reverses.append( Line 386: _( Line 387: 'Priorities were reversed during buildSequence: ' Line 380: Line 381: prio_dep_reverses = [] Line 382: for stage, methods in sequence.items(): Line 383: for i,m in enumerate(methods[:-1]): Line 384: if m['priority'] > methods[i+1]['priority']: space i + 1 for old pep8 Line 385: prio_dep_reverses.append( Line 386: _( Line 387: 'Priorities were reversed during buildSequence: ' Line 388: 'method %s with priority %s appears after ' Line 382: for stage, methods in sequence.items(): Line 383: for i,m in enumerate(methods[:-1]): Line 384: if m['priority'] > methods[i+1]['priority']: Line 385: prio_dep_reverses.append( Line 386: _( no need for gettext for debug, not critical. Line 387: 'Priorities were reversed during buildSequence: ' Line 388: 'method %s with priority %s appears after ' Line 389: 'method %s with priority %s' Line 390: ) % ( Line 397: if prio_dep_reverses: Line 398: msg = '\n'.join(prio_dep_reverses) Line 399: if self.environment[constants.BaseEnv.FAIL_ON_PRIO_OVERRIDE]: Line 400: raise RuntimeError(msg) Line 401: else: not sure this else is required... either: if xxxx: raise debug or, even: debug if xxxx: raise not critical Line 402: self._earlyDebug(msg) Line 403: self._sequence = sequence Line 404: Line 405: def runSequence(self): -- To view, visit http://gerrit.ovirt.org/29180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
