Daniel Erez has uploaded a new change for review. Change subject: webadmin: RegisterVmInfoPanel - getAppList nullity check ......................................................................
webadmin: RegisterVmInfoPanel - getAppList nullity check RegisterVmInfoPanel -> updateTabsData -> vm.getAppList() might return null on new VMs. Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Related-To-Bug-Url: https://bugzilla.redhat.com/1136756 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/78/32578/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java index 0db17c8..09a1398 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/RegisterVmInfoPanel.java @@ -10,6 +10,7 @@ import org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel; import org.ovirt.engine.ui.webadmin.section.main.view.popup.storage.backup.ImportVmGeneralSubTabView; +import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -46,7 +47,8 @@ disksTable.setRowData((List) Arrays.asList(vm.getDiskMap().values().toArray())); nicsTable.setRowData((List) Arrays.asList(vm.getInterfaces().toArray())); - appsTable.setRowData((List) Arrays.asList(vm.getAppList().split("[,]", -1))); //$NON-NLS-1$ + appsTable.setRowData((List) Arrays.asList(vm.getAppList() != null ? + vm.getAppList().split("[,]", -1) : new ArrayList<String>())); //$NON-NLS-1$ } private void initGeneralForm() { -- To view, visit http://gerrit.ovirt.org/32578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78346b1df26b203e5075385c0c7e67e8bd4c3344 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
