Roy Golan has posted comments on this change. Change subject: core: validate osinfo properties files - fail backend on error ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/30782/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java: Line 62: log.debugFormat("Osinfo Repository:\n {0}", toString()); Line 63: } Line 64: } Line 65: Line 66: @Override public void validateRepo() throws IllegalStateException { > please move @override to newline I just decided to not use is eventually. removing it in the commit patch Line 67: validateValues() Line 68: validateTree(); Line 69: } Line 70: Line 68: validateTree(); Line 69: } Line 70: Line 71: private void validateValues() { Line 72: this as well of course :( how clumsy of me Line 73: } Line 74: Line 75: private void validateTree() { Line 76: try { -- To view, visit http://gerrit.ovirt.org/30782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie33bf9446857e15d13221271120a3ff2b400350c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
