Yair Zaslavsky has posted comments on this change. Change subject: core: fix quota tests ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) Since this is DAO - I will give +2. Please verify that DAO test is not broken, and push/merge. .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java Line 21: private static final Long unlimited = -1L; Looks good. Just minor comment - please add on your todo list to change "ulimited" to be "UNLIMITED". Thanks! -- To view, visit http://gerrit.ovirt.org/6524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b2e0efe28c60828c12fafc7a38cd68a9d669d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
