Juan Hernandez has posted comments on this change. Change subject: packaging: build: fixed engine first clean build ......................................................................
Patch Set 1: What this patch is doing is syncing the definition of the repository with the one used in the restapi-parent POM. The identifier of the repository is important, as Maven uses it to compare artifacts. Artifacts with same coordinates and downloaded from the same repository are considered different by Maven if they are downloaded using different identifiers. So the patch is correct in those regards. However, I think that the repository definition should be removed from the restapi-parent POM, and we should never have references to snapshot repositories or snapshot artifacts outside of the reactor (outside of the project), as they challenge the stability of the build. -- To view, visit http://gerrit.ovirt.org/32635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e81cd257db9c3d57d5e626ab14f5027738b54c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
