Moti Asayag has posted comments on this change.
Change subject: core: update vm quota when action happens outside
......................................................................
Patch Set 1: (2 inline comments)
Adding Omer as a reviewer as well.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java
Line 65: void updateQuota(VM vm);
seems that you can pass here only the storagePoolId and the vmQuotaId rather
the entire VM entity.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1087: for (VM vm : running) {
I think that the correct place would be in afterRefreshTreatment, for the Vms
which detected as 'down' (_vmsMovedToDown)
--
To view, visit http://gerrit.ovirt.org/6520
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I610ee7caa57295b8418af2f29fcccaa463839a8d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
