Tal Nisan has submitted this change and it was merged. Change subject: core: clone vm - if the vm has only sharable disks they are not attached ......................................................................
core: clone vm - if the vm has only sharable disks they are not attached The problem was that the attachDisks() was called only from endSuccessfully() which was called only after the async tasks ended. But when there were no disks to copy, there were no async tasks so this method was not called. Fixed by moving the logic into the overridden addVmImages() method and detaching the disks in case of an error during copying the disks. Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Bug-Url: https://bugzilla.redhat.com/1124340 Signed-off-by: Tomas Jelinek <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2a8f4c35c68721e59c0b7e35c9148f148589794 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
