Piotr Kliczewski has uploaded a new change for review. Change subject: core: optional parameter storageFormatType not sent to vdsm ......................................................................
core: optional parameter storageFormatType not sent to vdsm storageFormatType is marked in jsonrpc schema as optional but it was not sent when the value was provided. Bug-Url: https://bugzilla.redhat.com/1139817 Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Signed-off-by: pkliczewski <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/32739/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java index 71e03db..bf603f0 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java @@ -528,13 +528,13 @@ String arg, int storageType, String storageFormatType) { - // storageFormatType not used and it can be removed from interface JsonRpcRequest request = new RequestBuilder("StorageDomain.create").withParameter("storagedomainID", sdUUID) .withParameter("domainType", domainType) .withParameter("typeArgs", arg) .withParameter("name", domainName) .withParameter("domainClass", storageType) + .withOptionalParameter("version", storageFormatType) .build(); Map<String, Object> response = new FutureMap(this.client, request); return new StatusOnlyReturnForXmlRpc(response); -- To view, visit http://gerrit.ovirt.org/32739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia09978bcd9228591735a15a8d4a827db9f1b3ef2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
