Maor Lipchuk has posted comments on this change. Change subject: core: Added VDS to StorageHandlingCommandBase jobProperties ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java Line 378: (getStoragePoolName() == null) ? "" : getStoragePoolName()); After talked with Moti, it seems that getting UNKNOWN string is better then empty string (PM opinion). so mkublin is right and there is no need for null validation. Derez, just verify that you get the appropriate message with 'UNKNOWN' -- To view, visit http://gerrit.ovirt.org/6527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia00d3c44d605a3a65084a9edfb10069441288146 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
