Livnat Peer has posted comments on this change.

Change subject: core: hot plug - use blacklist of unsupported list OSs
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I think the tests should fail after this fix.

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
Line 111: 
did you run the tests after this change?
shouldn't this test fail? RHEL3 is not on the black list so why should can do 
action fail?

--
To view, visit http://gerrit.ovirt.org/6548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I878c10cd3343e358d62e2506856e13c4d4b0332e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to