Moti Asayag has posted comments on this change. Change subject: engine:slave's mac in Broker, to lower case ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32577/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1436: iface.setMacAddress((String) nic.get("hwaddr")); Line 1437: // if we get "permhwaddr", we are a part of a bond and we use that as the mac address Line 1438: if (nic.get("permhwaddr") != null) { Line 1439: //TODO remove when the minimal supported vdsm version is >=3.6 Line 1440: // in older VDSM version, slave's Mac is in upper case this is not the same change as merged to master. please extract nic.get("") into a local variable. Line 1441: String macUpperCase = (String) nic.get("permhwaddr"); Line 1442: iface.setMacAddress(macUpperCase.toLowerCase()); Line 1443: } Line 1444: if (StringUtils.isNotBlank((String) nic.get(VdsProperties.MTU))) { -- To view, visit http://gerrit.ovirt.org/32577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec2c04bca879c97835d95330c130f2a4ca16587 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eliraz Levi <[email protected]> Gerrit-Reviewer: Eliraz Levi <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
