Maor Lipchuk has posted comments on this change.
Change subject: core: BaseImagesCommand: solved Eclipse warnings
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 423: protected void
AdditionalImageRemoveTreatment(@SuppressWarnings("unused") DiskImage snapshot) {
If you already changing this method why not removing it completely.
extra bonus for doing it, is to finally remove a Vitaly comment (at
RestoreFromSnapshotCommand@AdditionalImageRemoveTreatment)
--
To view, visit http://gerrit.ovirt.org/6400
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36c6ffe9b17e8ff65e99c8b715cd9a30224e10ab
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
