Alon Bar-Lev has posted comments on this change. Change subject: pkg: Addapt packaging to use splitted modules dirs ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/32846/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-09-10 10:34:38 +0200 Line 4: Commit: Martin Perina <[email protected]> Line 5: CommitDate: 2014-09-12 10:20:20 +0200 Line 6: Line 7: pkg: Addapt packaging to use splitted modules dirs packaging: Line 8: Line 9: Addapt packaging stuff to use splitted modules directories. Line 10: Line 11: Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb http://gerrit.ovirt.org/#/c/32846/1/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 119: # Line 120: # JBoss is always appended, cannot be appended here Line 121: # as it may be resolved to different value. Line 122: # Line 123: # - Line 124: # Module path used inside JBoss instance Line 125: # Line 126: ENGINE_JBOSS_JAVA_MODULEPATH="${ENGINE_USR}/modules/instance:${ENGINE_USR}/modules/common" Line 127: # Line 125: # Line 126: ENGINE_JBOSS_JAVA_MODULEPATH="${ENGINE_USR}/modules/instance:${ENGINE_USR}/modules/common" Line 127: # Line 128: # Module path used in standalone tools Line 129: ENGINE_TOOLS_JAVA_MODULEPATH="${ENGINE_USR}/modules/standalone:${ENGINE_USR}/modules/common" please note that these are the defaults... as people should add ENGINE_JAVA_MODULEPATH and effect tools as well, and it won't. so I suggest that ENGINE_JAVA_MODULEPATH is used for common and then at engine-epilogue and at engine service we append the jboss/tools at end of path. in notifier you can put the tools within default as there is only one. Line 130: Line 131: # Line 132: # Additional applications to be deployed in the instance of the Line 133: # application server started by the engine. This is a list of space -- To view, visit http://gerrit.ovirt.org/32846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
