Roy Golan has posted comments on this change.

Change subject: core: Fail Add/Update Vm when CPU is unsupported
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/32926/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java:

Line 278:      * @param osId
Line 279:      * @param version
Line 280:      * @return
Line 281:      */
Line 282:     public Set<String> getUnsupportedCpus(int osId, Version version);
push this down to first patch
Line 283:     /**
Line 284:      * Some Operating Systems don't support certain CPUs. As a result 
of working
Line 285:      * with one,the guest OS might stop working, blue-screen, oops, 
or other well known red lights.
Line 286:      * @param osId


-- 
To view, visit http://gerrit.ovirt.org/32926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1d22994c59b16d1d71d2315882d41454079bf32
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to