Ori Liel has posted comments on this change.
Change subject: work in progress - don't submit - engine: User level API fixes
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 83: private VM handleResponse(VM vm) {
I'd go with a more informative name for this method, perhaps something like
removeRestrictedInfo(), enforcePermissions()... handleResponse() is very general
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
Line 45: public void testQueryWithFilter() throws Exception {
Bad luck that the general resource test uses hosts, and therefore this test now
throws exception.
We need to add another test for filter=true in a legal case (not getting a
host).
--
To view, visit http://gerrit.ovirt.org/6542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90032cdd70130dbab7b11457684d9130f763d5db
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
