Tal Nisan has posted comments on this change. Change subject: core: fix removal of lun disk with no vm (#841265) ......................................................................
Patch Set 1: Not sure why the change is necessary, the NPE is not happening anymore, I fixed it a few days ago cause I stumbled in it when working on a different bug. What you basically do here is call getVmsForDiskId AFTER it's been invoked the first time in buildSharedLockMap, what it does is return you listVMs from the cache, so this doesn't really do anything different -- To view, visit http://gerrit.ovirt.org/6566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad5a09962da87d9e3f8d06685daf2f64ed751fd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
