Roy Golan has submitted this change and it was merged. Change subject: core: QueriesCommandTest: removed wrong test ......................................................................
core: QueriesCommandTest: removed wrong test Removed a test in QueriesCommandBase that essentially checked that the construction of a query from VdcQueryType works. First, this test should not be here. Second, since several queries init static blocks that depend on external resources (that should be mocked, but aren't here), it may cause other tests to fail. Change-Id: I9f8d5df49dbe78a8288021567907e31ff53a75a3 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java 1 file changed, 0 insertions(+), 40 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f8d5df49dbe78a8288021567907e31ff53a75a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
