Allon Mureinik has posted comments on this change. Change subject: core: Implement toString() in StorageDomain,StorageDomainStatic,StoragePool ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/32977/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java: Line 353: public String toString() { Line 354: // Since the static data arrives from external source it's not guarenteed not to be null so a null check is Line 355: // mandatory in order to avoid NPE when invoking toString by the logger Line 356: String domainName = staticData.getName() == null ? "null" : staticData.getName(); Line 357: String domainId = staticData.getId() == null ? "null" : staticData.getId().toString(); you don't need this. the "+" operator does this for you. Line 358: return "StorageDomain[" + domainName + ", " + domainId + "]"; Line 359: } -- To view, visit http://gerrit.ovirt.org/32977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a70ea21e6c5996d430eef013c5d93360aa04e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
