Hello Ravi Nori,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33009
to review the following change.
Change subject: engine : Dont set flowid in UI code
......................................................................
engine : Dont set flowid in UI code
The frontend code should not set flowid
for reports webapp
Change-Id: I83fccc71cfac53b30a117628bb84e76947fef67b
Bug-Url: https://bugzilla.redhat.com/1116851
Signed-off-by: Ravi Nori <[email protected]>
(cherry picked from commit 2f5e6daf1174070d0677c9adb565bd7f90441a75)
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
2 files changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/33009/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
index 422140c..db90be9 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java
@@ -18,7 +18,6 @@
reportUrl = baseUrl;
paramsMap.setParameter("sessionID", ssoToken); //$NON-NLS-1$
- paramsMap.setParameter("_flowId", "viewReportFlow"); //$NON-NLS-1$
//$NON-NLS-2$
paramsMap.setParameter("active_hosts_select", //$NON-NLS-1$
"AND+delete_date+IS+NULL"); //$NON-NLS-1$
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
index d6bbb7d..7e7bf22 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java
@@ -31,8 +31,6 @@
reportUrl = baseUrl;
htmlParams.setParameter("sessionID", ssoToken); //$NON-NLS-1$
- setFlowId();
-
String currentLocale = LocaleInfo.getCurrentLocale().getLocaleName();
htmlParams.setParameter("userLocale", (currentLocale.equals("default")
? "en_US" : currentLocale)); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
@@ -52,14 +50,6 @@
public String getUrl() {
return reportUrl;
- }
-
- private void setFlowId() {
- if (ReportInit.getInstance().isCommunityEdition()) {
- htmlParams.setParameter("_flowId", "viewReportFlow");
//$NON-NLS-1$ //$NON-NLS-2$
- } else {
- htmlParams.setParameter("_flowId", "dashboardRuntimeFlow");
//$NON-NLS-1$ //$NON-NLS-2$
- }
}
public void setPassword(String password) {
--
To view, visit http://gerrit.ovirt.org/33009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83fccc71cfac53b30a117628bb84e76947fef67b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
