Roy Golan has posted comments on this change. Change subject: core: Lazy load of Vms per VDS ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32669/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1347: for (VmInternalData runningVm : _runningVms.values()) { Line 1348: tempRunningList.add(runningVm.getVmDynamic()); Line 1349: } Line 1350: for (VmDynamic runningVm : tempRunningList) { Line 1351: VM vmToUpdate = getVmDict().get(runningVm.getId()); > another scenrio this is an improvement is when host throws exception (netwo this might already being taken care of in VmsListFetcher Line 1352: Line 1353: boolean statusChanged = false; Line 1354: if (vmToUpdate == null Line 1355: || (vmToUpdate.getStatus() != runningVm.getStatus() && Line 1347: for (VmInternalData runningVm : _runningVms.values()) { Line 1348: tempRunningList.add(runningVm.getVmDynamic()); Line 1349: } Line 1350: for (VmDynamic runningVm : tempRunningList) { Line 1351: VM vmToUpdate = getVmDict().get(runningVm.getId()); > liran, like you mentioned this would only save the call if there are no VMs to make cleaer - , not against the idea - just want to get your observations Line 1352: Line 1353: boolean statusChanged = false; Line 1354: if (vmToUpdate == null Line 1355: || (vmToUpdate.getStatus() != runningVm.getStatus() && -- To view, visit http://gerrit.ovirt.org/32669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic61f8d965083b814b64257831a2ed3c6d7f764c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
