Vojtech Szocs has posted comments on this change. Change subject: gluster-nagios-monitoring: fixing extra login popup from trends tab. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33060/1/gluster-nagios-monitoring/src/js/services.js File gluster-nagios-monitoring/src/js/services.js: Line 4: Line 5: var alertService = function ($http) { Line 6: return { Line 7: getAlerts: function() { Line 8: return $http({method: 'GET', url: '/ovirt-engine/api/events?search=severity%3Dalert', headers: {Accept: 'application/json', Prefer: 'persistent-auth'}}). Hm, I'd advise to improve code a bit like this: var headers = {Accept: 'application/json', Prefer: 'persistent-auth'}; ... return $http({method: 'someMethod', url: 'someUrl', headers: headers}) ... What do you think? Also, you could consider using shortcut methods like this: ... return $http.get('someUrl', {headers: headers}) ... Line 9: then(function (response) { Line 10: if(typeof response.data.event !== 'undefined') { Line 11: return response.data.event; Line 12: } -- To view, visit http://gerrit.ovirt.org/33060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dba4af5cef01a5d30ed24831bd2333ba9ae05bd Gerrit-PatchSet: 1 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
