Livnat Peer has posted comments on this change.
Change subject: core: Ignore gateway for non-management net (#842137)
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
assuming the answer to my inline question is yes, this patch looks good to me.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 920: iface.setSubnet((String) bond.get("netmask"));
Just making sure - this line was removed because the gateway is set in the
AddBootProtocol method?
--
To view, visit http://gerrit.ovirt.org/6585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica928d0c774220339004e93110ecda742d6967f1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
