Maor Lipchuk has uploaded a new change for review. Change subject: core: Validate disk registration only if a domain exists. ......................................................................
core: Validate disk registration only if a domain exists. Registeration of a disk is only a DB operation and does not encounter any VDS commands, therefore there should not be any validation for Storage Domain activation. Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Related to Bug-Url: https://bugzilla.redhat.com/1138114 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/33102/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java index 361ee5b..7257437 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java @@ -47,7 +47,7 @@ return false; } - if (!validate(new StorageDomainValidator(getStorageDomain()).isDomainExistAndActive())) { + if (!validate(new StorageDomainValidator(getStorageDomain()).isDomainExist())) { addCanDoActionMessageVariable("diskId", getParameters().getDiskImage().getId()); addCanDoActionMessageVariable("domainId", getStorageDomainId()); addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_UNAVAILABLE); -- To view, visit http://gerrit.ovirt.org/33102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71c138ede22808b5a887e9b9982c154e5591d5c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
