Ori Liel has posted comments on this change.

Change subject: restapi: Enable Using Lowercase Usage in Network (#817798)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
Line 61:                 networkUsages.add(NetworkUsage.fromValue(usage));
This way you're not using the mapping function, and you're counting on enum 
values to be identical in the Backend enum and in the Rest-API enum. 

To use the mapping function, replace this line with: 

networkUsages.add(map(NetworkUsage.fromValue(usage), null));

--
To view, visit http://gerrit.ovirt.org/6502
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id77c90d094f09516f7e23ae55116af7c6b08b651
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to