Omer Frenkel has posted comments on this change. Change subject: core: VM Monitoring abstract fetching/analyzing/monitoring ......................................................................
Patch Set 11: (4 comments) http://gerrit.ovirt.org/#/c/28662/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 160: UpdateVmPolicy("org.ovirt.engine.core.vdsbroker"), Line 161: List("org.ovirt.engine.core.vdsbroker.vdsbroker"), // get a list of VMs with status only Line 162: GetVmStats("org.ovirt.engine.core.vdsbroker.vdsbroker"), // get a VM with full data and statistics Line 163: GetAllVmStats("org.ovirt.engine.core.vdsbroker.vdsbroker"), // get a list of VMs with full data and statistics Line 164: Destroy("org.ovirt.engine.core.vdsbroker.vdsbroker"); // Clean a DOWN VM from the vms list comment should be "Stop vm and also Clean a..." Line 165: Line 166: String packageName; Line 167: Line 168: private VDSCommandType(String packageName) { http://gerrit.ovirt.org/#/c/28662/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 446: Line 447: return null; Line 448: } Line 449: Line 450: public VmManager getVmManager(Guid vmId) { why did you change this? Line 451: if (vmManagers.contains(vmId)) { Line 452: return vmManagers.get(vmId); Line 453: } else { Line 454: VmManager value = new VmManager(vmId); http://gerrit.ovirt.org/#/c/28662/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 287: ).perform(); Line 288: } Line 289: } Line 290: Line 291: VDS getVds() { public? why return clone? Line 292: return cachedVds.clone(); Line 293: } Line 294: public String getVdsName() { Line 295: return cachedVds.getName(); http://gerrit.ovirt.org/#/c/28662/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java: Line 50: /** Line 51: * Responsible of comparing 2 views of the same VM, one from DB and other as reported from VDSM, run checks, see what changed Line 52: * and record what's changed in its internal state. Line 53: */ Line 54: public class VmAnalyzer { its hard to follow any changes, i assume all code here is taken as-is from vurti without logic changes? Line 55: Line 56: private VM dbVm; Line 57: private final VmInternalData vdsmVm; Line 58: -- To view, visit http://gerrit.ovirt.org/28662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1adf0a95007140e89b080b5160ba93e340ee3ba6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
