Ori Liel has posted comments on this change. Change subject: restapi: removing access protocols and acl in create volume ......................................................................
Patch Set 1: I agree that it's redundant and error prone to allow user to update the same thing in two different ways, but I'm thinking why not leave the strongly-typed way, instead of the string-based way, the 'option'? Also, this change you're proposing would break API and we must be backwards compatible. I believe that in such an early stage of the Gluster rest-api lifecycle we can go ahead and break anyway, but to be safe maybe it's better to run it though engine-devel mailing list, to give people the opportunity to object. -- To view, visit http://gerrit.ovirt.org/6410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0dad83cc2e3dc0dfb698677084150d870289eff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
