Allon Mureinik has posted comments on this change. Change subject: core: Improve attach process when register disks ......................................................................
Patch Set 2: Code-Review-1 (1 comment) -1 on log bug. Also - no tests? http://gerrit.ovirt.org/#/c/33154/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 325: Line 326: // We can't deal with snapshots, so there should only be a single volume associated with the Line 327: // image. If there are multiple volumes, skip the image and move on to the next. Line 328: if (volumesList.size() != 1) { Line 329: log.infoFormat("Could not get populated disk image id {1} since the disk contains snapshots.", MessageFormat is zero based, not one based. Line 330: unregisteredDiskId); Line 331: return; Line 332: } Line 333: -- To view, visit http://gerrit.ovirt.org/33154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
