Daniel Erez has posted comments on this change.

Change subject: webadmin: Adding support to import GlusterFS
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/33211/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java:

Line 2036:                         
tempVar.setMountOptions(posixModel.getMountOptions().getEntity());
Line 2037:                     }
Line 2038:                     if (storageModel instanceof GlusterStorageModel) 
{
Line 2039:                         GlusterStorageModel glusterModel = 
(GlusterStorageModel) storageModel;
Line 2040:                         
tempVar.setVfsType(glusterModel.getVfsType().getEntity());
please rename 'tempVar' on later patch..
Line 2041:                         
tempVar.setMountOptions(glusterModel.getMountOptions().getEntity());
Line 2042:                     }
Line 2043:                     storageListModel.fileConnection = tempVar;
Line 2044:                     storageListModel.importFileStorageConnect();


-- 
To view, visit http://gerrit.ovirt.org/33211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to