Hello Alona Kaplan,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33296
to review the following change.
Change subject: webadmin: adding '...' appender to text columns that overflow
......................................................................
webadmin: adding '...' appender to text columns that overflow
Using TextOverflow.ELLIPSIS style property to achieve this.
Bug-Url: https://bugzilla.redhat.com/1122990
Signed-off-by: Greg Sheremeta <[email protected]>
Signed-off-by: Alona Kaplan <[email protected]>
Change-Id: I4978290d75286eb18358d97de1862c406ac8e89f
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/33296/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
index e893885..2c36358 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java
@@ -1,7 +1,5 @@
package org.ovirt.engine.ui.common.widget.table.column;
-import com.google.gwt.user.client.ui.HTML;
-
import org.ovirt.engine.ui.common.utils.ElementIdUtils;
import com.google.gwt.core.client.GWT;
@@ -12,6 +10,7 @@
import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
import com.google.gwt.user.client.DOM;
+import com.google.gwt.user.client.ui.HTML;
/**
* A Cell used to render text, providing tooltip in case the content doesn't
fit the parent element.
@@ -22,7 +21,7 @@
interface CellTemplate extends SafeHtmlTemplates {
- @Template("<div class=\"{0}\" id=\"{1}\">{2}</div>")
+ @Template("<div class=\"{0}\" style='overflow: hidden; text-overflow:
ellipsis; white-space: nowrap;' id=\"{1}\">{2}</div>")
SafeHtml textContainer(String style, String id, SafeHtml text);
}
--
To view, visit http://gerrit.ovirt.org/33296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4978290d75286eb18358d97de1862c406ac8e89f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
