Selvasundaram has posted comments on this change.

Change subject: engine: Brick existance validation for add brick
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 186:     private boolean isValidBricks(List<GlusterBrickEntity> newBricks) 
{
Done

Line 198:     private boolean brickExist(GlusterBrickEntity newBrick) {
Done

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 622:     ACTION_TYPE_FAILED_BRICK_ALREADY_EXIST_IN_VOLUME,
Done

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 754: ACTION_TYPE_FAILED_BRICK_ALREADY_EXIST_IN_VOLUME=Cannot ${action} 
${type}. Brick ${brick} already used by the volume ${volumeName}.
Done

--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93eb97560bc02157683983aa4e65cfb187bdb97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to