Roy Golan has posted comments on this change.
Change subject: engine: Edit Pool shows different RAM than defined (#833829)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 264: // no need for DataMember, it's setter and calculated from 2
other fields
pls convert to javadoc
Line 272: public void setnum_of_cpus(int val) {
we aren't using CXF or soap long ago. this can be removed
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
Line 35: setupWindowModelFrom(pool.getStaticData());
who fires setupWindowModelFrom if this model is changed? I'm probably missing
GWT knowledge here.
--
To view, visit http://gerrit.ovirt.org/6638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idaa1a92f7fe85f9c604da8916be5672d8d5b1e8b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
