Alon Bar-Lev has posted comments on this change. Change subject: notifier: modify the oid schema for SNMP notification. ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/32951/4/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 160: new OID(auditObjects).append(3), Line 161: new Integer32(event.getSeverity().getValue()))); Line 162: v2pdu.add(new VariableBinding( Line 163: new OID(auditObjects).append(4), Line 164: new OctetString(event.getMessage()))); > Actually I wont be doing this since it causes some problems. I do not follow what is $4 in this context, I think you refer to the manager configuration. Line 165: v2pdu.add(new VariableBinding( Line 166: new OID(auditObjects).append(5), Line 167: new Integer32(event.getType().getValue()))); Line 168: v2pdu.add(new VariableBinding( Line 224: v2pdu.add(new VariableBinding( Line 225: new OID(auditObjects).append(17), Line 226: new OctetString(event.getStorageDomainName()))); Line 227: } Line 228: if (event.getStorageDomainId() != null && !event.getStorageDomainId().equals(Guid.Empty)) { > Right. and guid should also be a wrapper. I also suggest you add boolean allowEmpty so that this function will used all over. Line 229: v2pdu.add(new VariableBinding( Line 230: new OID(auditObjects).append(18), Line 231: new OctetString(event.getStorageDomainId().toString()))); Line 232: } -- To view, visit http://gerrit.ovirt.org/32951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
