Doron Fediuck has posted comments on this change. Change subject: webadmin: translation of cpu err msg (#834870) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Need minor fixups. See inline. .................................................... Commit Message Line 11: There was no translation to the error message when cpu pinning a/was/is Line 12: format was wrong General commit message concepts: 1. Subjcet: short and descriptive. 2. What was the problem 3. How this change resolves the problem. (make sure to comply with general git line length). So for this BZ, I'd go with something like: webadmin: Complete text for of cpu err msg (#834870) When a user specifies bad format in CPU pinning topology, an error code is received, instead of the relevant translated text. This fix adds the error key to AppErrors, so it will get translated and the user will get a proper notification. -- To view, visit http://gerrit.ovirt.org/6600 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id86194930eedcfe10f3c16c189212bd9af3e4859 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
