Maor Lipchuk has posted comments on this change.
Change subject: core:Edit job message referencing template(#818295)
......................................................................
Patch Set 2:
Where is this bundle used?
ExecutionMessageDirector#getMessage + resolveJobMessage
Are you sure ${StoragePool} is parsed?
All parameters parse from the getPermissionCheckSubjects if some parameter is
not validate for permission it should be checked through getJobMessageProperties
--
To view, visit http://gerrit.ovirt.org/6353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5d41889360cf7bc309e9e9a49fb0298269c7984
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
