Sandro Bonazzola has posted comments on this change. Change subject: core: making parseTypedValue more severe ......................................................................
Patch Set 1: Just to clarify, if user generate an answer file and get: OSETUP_RPMDISTRO/enableUpgrade=none:None and then edit the answer file by hand assuming that the type shouldn't be touched but the value should, he/she'll set: OSETUP_RPMDISTRO/enableUpgrade=none:True instead of OSETUP_RPMDISTRO/enableUpgrade=bool:True and no error will be raised while parsing the config file, just causing the application to behave as the user didn't change the answer file. With this change we can detect this parsing errors earlier in the setup execution. -- To view, visit http://gerrit.ovirt.org/33370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I356b0d8029d9785bff54744614ed1e679c32529c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
