Arik Hadas has posted comments on this change. Change subject: core: Remove printStackTrace from VmHandler ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33423/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 827: Boolean isEnabled = null; Line 828: try { Line 829: isEnabled = (Boolean) field.get(objectWithEditableDeviceFields); Line 830: } catch (IllegalAccessException | ClassCastException e) { Line 831: log.warn("VmHandler:: isUpdateValidForVmDevices: Reflection error"); how about adding the message from the exception to the log message to provide more information? Line 832: } Line 833: Line 834: // if device type is set to unknown, search by general type only Line 835: // because some devices has more than one type, like sound can be ac97/ich6 -- To view, visit http://gerrit.ovirt.org/33423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ec33e5c8cb319fed39d6934fae63b413d2b378a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
