Alon Bar-Lev has posted comments on this change. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ......................................................................
Patch Set 4: Code-Review+1 (3 comments) +1 as it is not that important right now, but I still think pom should be simpler. http://gerrit.ovirt.org/#/c/33323/4/build/validations/pom.xml File build/validations/pom.xml: Line 4: <groupId>org.ovirt.engine</groupId> Line 5: <artifactId>root</artifactId> Line 6: <relativePath>../../pom.xml</relativePath> Line 7: <version>3.6.0-SNAPSHOT</version> Line 8: </parent> I do not like we include the root pom here... too many definitions, it also refers to other modules. but if it is the best way to do it in maven, then ok. Line 9: Line 10: <name>build-validations</name> Line 11: <artifactId>build-validations</artifactId> Line 12: <groupId>org.ovirt.engine.build</groupId> Line 16: <groupId>org.ovirt.engine.core</groupId> Line 17: <artifactId>utils</artifactId> Line 18: <version>${engine.version}</version> Line 19: <scope>test</scope> Line 20: </dependency> if we leave only this dependency, there is no reason why not specify <version>3.6.0-SNAPSHOT</version>. in other words, I think the above is the only required dependency without and parent. Line 21: <dependency> Line 22: <groupId>org.antlr</groupId> Line 23: <artifactId>antlr4-runtime</artifactId> Line 24: <version>${antlr.version}</version> Line 22: <groupId>org.antlr</groupId> Line 23: <artifactId>antlr4-runtime</artifactId> Line 24: <version>${antlr.version}</version> Line 25: <scope>test</scope> Line 26: </dependency> I truly think this dependency can go into the test scope of the utils instead of having it here... but again, if maven does not permit that, then... Line 27: </dependencies> Line 28: -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
