Livnat Peer has posted comments on this change. Change subject: core: Added method to fill network details ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java Line 129: I think it is bad practice in Java to update the method input parameters. I would change the code to return it as a return value. -- To view, visit http://gerrit.ovirt.org/6647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5634fa47f30096e4c58bf3186ccba53f2fa3bbd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
