Juan Hernandez has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 3: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32849/3/backend/manager/dependencies/tools/src/main/modules/org/slf4j/main/module.xml File backend/manager/dependencies/tools/src/main/modules/org/slf4j/main/module.xml: Line 1: <?xml version="1.0" encoding="UTF-8"?> I'd suggest to put a comment here explaining why this apparently unnecessary module is required. Line 2: Line 3: <module xmlns="urn:jboss:module:1.1" name="org.slf4j"> Line 4: <resources> Line 5: <resource-root path="slf4j-api.jar"/> -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
