Vered Volansky has uploaded a new change for review. Change subject: core: Removed redundant tests ......................................................................
core: Removed redundant tests After the refactoring of storage allocation there's no longer need for tests of the 'old' verifications in StorageDomainValidatorTest. Removed. Change-Id: I5270d2ee1c1a567f61ab9813ffe2d223e062d8a0 Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 1 file changed, 0 insertions(+), 29 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/33708/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java index 42e8f7f..9478930 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java @@ -61,40 +61,11 @@ } @Test - public void testDomainWithNotEnoughSpaceForRequest() { - validator = new StorageDomainValidator(mockStorageDomain(12, 748, StorageType.NFS)); - assertEquals("Wrong failure for not enough space for request", - VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN, - validator.isDomainHasSpaceForRequest(10).getMessage()); - } - - @Test public void testDomainWithNotEnoughSpace() { validator = new StorageDomainValidator(mockStorageDomain(3, 756, StorageType.NFS)); assertEquals("Wrong failure for not enough space", VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN, validator.isDomainWithinThresholds().getMessage()); - } - - @Test - public void testDomainWithNotEnoughSpaceForRequestWithoutThreshold() { - validator = new StorageDomainValidator(mockStorageDomain(12, 748, StorageType.NFS)); - assertEquals("Wrong failure for not enough space for request", - VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN, - validator.isDomainHasSpaceForRequest(13, false).getMessage()); - } - - @Test - public void testDomainWithEnoughSpaceForRequestWithoutThreshold() { - validator = new StorageDomainValidator(mockStorageDomain(12, 748, StorageType.NFS)); - assertTrue("Domain should have enough space for request.", validator.isDomainHasSpaceForRequest(12, false) - .isValid()); - } - - @Test - public void testDomainWithEnoughSpaceForRequest() { - validator = new StorageDomainValidator(mockStorageDomain(16, 748, StorageType.NFS)); - assertTrue("Domain should have more space then threshold", validator.isDomainHasSpaceForRequest(10).isValid()); } @Test -- To view, visit http://gerrit.ovirt.org/33708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5270d2ee1c1a567f61ab9813ffe2d223e062d8a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
