Omer Frenkel has posted comments on this change. Change subject: engine: VmPayload needs to inherit from VmDevice ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33679/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java: Line 29: Line 30: for (VmDevice disk : disks) { Line 31: if (VmPayload.isPayload(disk.getSpecParams())) { Line 32: VmPayload payload = new VmPayload(disk); Line 33: payload.setDeviceType(VmDeviceType.valueOf(disk.getDevice().toUpperCase())); this line is not needed anymore, right? because the VmPayload ctor already do this set Line 34: for (Map.Entry<String, String> entry : payload.getFiles().entrySet()) { Line 35: entry.setValue(new String(Base64.decodeBase64(entry.getValue()))); Line 36: } Line 37: http://gerrit.ovirt.org/#/c/33679/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 88: Line 89: for (VmDevice disk : disks) { Line 90: if (VmPayload.isPayload(disk.getSpecParams())) { Line 91: VmPayload payload = new VmPayload(disk); Line 92: payload.setDeviceType(VmDeviceType.valueOf(disk.getDevice().toUpperCase())); this is probably not needed Line 93: getVm().setVmPayload(payload); Line 94: break; Line 95: } Line 96: } -- To view, visit http://gerrit.ovirt.org/33679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieabf99eaaff0d6e68a0521af3df43a774ca31590 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
