Gilad Chaplik has posted comments on this change. Change subject: core: Handle NUMA preferred tune mode ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/33517/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 108: /** Line 109: * preferred supports single pinned vnuma node (without that VM fails to run in libvirt). Line 110: * used by add/update VM commands Line 111: */ Line 112: public static VdcBllMessages checkNumaPreferredTuneMode(NumaTuneMode numaTuneMode, > this looks like should be in VmHandler and use the same stlye with Validati Done Line 113: List<VmNumaNode> vmNumaNodes, Line 114: Guid vmId) { Line 115: // check tune mode Line 116: if (numaTuneMode != NumaTuneMode.PREFERRED) { -- To view, visit http://gerrit.ovirt.org/33517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
