Gilad Chaplik has uploaded a new change for review. Change subject: core: avoid sending NUMA values if not specified ......................................................................
core: avoid sending NUMA values if not specified Currently NUMA Tune Mode is sent even if VM doesn't have virtual NUMA nodes configured. Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Bug-Url: https://bugzilla.redhat.com/1147261 Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/33733/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java index 5801002..daf3a19 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java @@ -1138,8 +1138,11 @@ private void addNumaSetting(final String compatibilityVersion) { if (Boolean.TRUE.equals(Config.<Boolean> getValue(ConfigValues.CpuPinningEnabled, compatibilityVersion))) { - NumaTuneMode numaTune = vm.getNumaTuneMode(); List<VmNumaNode> vmNumaNodes = DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId()); + if (vmNumaNodes.isEmpty()) { + return; + } + NumaTuneMode numaTune = vm.getNumaTuneMode(); List<VdsNumaNode> totalVdsNumaNodes = DbFacade.getInstance().getVdsNumaNodeDAO() .getAllVdsNumaNodeByVdsId(vdsId); if (numaTune != null) { -- To view, visit http://gerrit.ovirt.org/33733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
