Hello Antoni Segura Puimedon,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33802
to review the following change.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
......................................................................
frontend: Fix disk creation NPE on diskprofile selection
I was getting a NullPointer Exception when adding disks in oVirt 3.5
prerelease.
Bug-Url: https://bugzilla.redhat.com/1149442
Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Signed-off-by: Antoni S. Puimedon <[email protected]>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/33802/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
index 0196f72..3ce5a1d 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
@@ -949,7 +949,10 @@
}
if (getDisk().getDiskStorageType() == DiskStorageType.IMAGE) {
- ((DiskImage)
getDisk()).setDiskProfileId(getDiskProfile().getSelectedItem().getId());
+ DiskProfile selectedDiskProfile =
getDiskProfile().getSelectedItem();
+ if (selectedDiskProfile != null) {
+ ((DiskImage)
getDisk()).setDiskProfileId(selectedDiskProfile.getId());
+ }
}
getDisk().setDiskAlias(getAlias().getEntity());
getDisk().setDiskDescription(getDescription().getEntity());
--
To view, visit http://gerrit.ovirt.org/33802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
